feat: facebook pixel audit refactor #2706

sandeepdsvs · 2023-10-10T09:31:56Z

Description of the change

Refactored Facebook Pixel transformer logic. No new features or enhancements, involves pure tech refactoring.

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

codecov · 2023-10-10T09:38:05Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6e20a72) 87.20% compared to head (5abe273) 87.22%.
Report is 6 commits behind head on develop.

❗ Current head 5abe273 differs from pull request most recent head 33b8006. Consider uploading reports for the commit 33b8006 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2706      +/-   ##
===========================================
+ Coverage    87.20%   87.22%   +0.01%     
===========================================
  Files          640      640              
  Lines        28467    28435      -32     
  Branches      6762     6746      -16     
===========================================
- Hits         24826    24802      -24     
+ Misses        3314     3306       -8     
  Partials       327      327

Files	Coverage Δ
src/v0/destinations/facebook_pixel/config.js	`100.00% <100.00%> (ø)`
src/v0/destinations/facebook_pixel/transform.js	`98.50% <100.00%> (+4.89%)`	⬆️
src/v0/destinations/facebook_pixel/utils.js	`96.84% <94.11%> (-0.67%)`	⬇️